Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git effort run on FreeBSD #404

Merged
merged 3 commits into from
Jul 29, 2015
Merged

Make git effort run on FreeBSD #404

merged 3 commits into from
Jul 29, 2015

Conversation

nicolaiskogheim
Copy link
Collaborator

This should fix #402

@yggdr

Most implementations of seq yields no output for 'seq 0',
but some yields '1(newline)0'.
@yggdr
Copy link
Contributor

yggdr commented Jul 28, 2015

This version is now works in principle, but seems to have problems with tracked files with spaces in their names (missing quotation?), and outputs a lot of lines that seem empty at first glance, but are actually just the exact colour of my background :(

@nicolaiskogheim
Copy link
Collaborator Author

I have seen that color problem before. The darkest colors from git effort is the same as the background color for Solaris-themed terminals.

I'll test for files with spaces.

@nicolaiskogheim
Copy link
Collaborator Author

So, I suggest we merge in this one, and take it from there.

Quoting and coloring are separate issues that affects everyone, not just FreeBSD.

@hemanth

@hemanth
Copy link
Collaborator

hemanth commented Jul 29, 2015

Makes sense.

hemanth added a commit that referenced this pull request Jul 29, 2015
@hemanth hemanth merged commit 46db569 into tj:master Jul 29, 2015
@nicolaiskogheim nicolaiskogheim deleted the freebsd-fix branch August 3, 2015 21:53
@qw3rtman qw3rtman mentioned this pull request Dec 27, 2015
tardypad pushed a commit to tardypad/git-extras that referenced this pull request Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git effort errors out with bash errors on FreeBSD 10.1
3 participants