[RFC] effort: Allow sending options to log. Fix #326 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaiskogheim
changed the title
|
//cc @spacewander |
|
This is a good idea. |
|
@nicolaiskogheim Please go ahead and complete the PR :) |
|
This is finally working as it should now. The man page and completion remains. I should have that done soon. |
|
👍 |
|
All done. |
|
Hold on a bit. I think I found a way to avoid using Edit: Nope, didn't work. This is ready to be merged in as far as I can tell. |
hemanth
added a commit
that referenced
this pull request
Jul 25, 2015
[RFC] effort: Allow sending options to log. Fix #326
|
Done. Cool 👍 |
Closed
tardypad
pushed a commit
to tardypad/git-extras
that referenced
this pull request
Jul 13, 2016
[RFC] effort: Allow sending options to log. Fix tj#326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up for discussion.
This makes it possible for
git effortto take other options other than--above.These get sent to
git login effort().So this is possible now:
git effort --since="one year ago" --until="one week ago" --above 10 mydir/*Invalid options is handled by git log, which I think is nice.
Note though: The original issue wanted to have these options to speed up the process by limiting the commit history, but there is no remarkable performance gain by this as far as I were able to see.
TODO if this is wanted: