Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing quote in git-extras-completion.zsh #1078

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

Gerrit-K
Copy link
Contributor

Broken in #1074

@Gerrit-K
Copy link
Contributor Author

Note: I have no idea why this echo is even there 😉 Just wanted to fix syntax errors. If this is a debugging leftover to be removed or someone has a better idea for a fix, feel free to close and take over 👍

@hyperupcall
Copy link
Collaborator

hyperupcall commented Sep 22, 2023

@spacewander Sorry if I didn't make it clear that I wasn't quite done with ZSH modifications in #1074. I have made #1079 that hotfixes the issue (reverting back to working completion) so consumers don't get syntax error.

@Gerrit-K Thanks for making this PR or otherwise I would have missed this for later

@spacewander spacewander merged commit e4152db into tj:master Sep 22, 2023
5 checks passed
@spacewander
Copy link
Collaborator

@hyperupcall
I merged @Gerrit-K's fix first to thank for his/her report.
Would you update #1079 so I can merge it too?
Thanks!

@hyperupcall
Copy link
Collaborator

@spacewander absolutely, i just rebased over master 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants