Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-rename-branch arguments are in wrong order #759

Closed
btmurrell opened this issue Jun 11, 2019 · 5 comments · Fixed by #767
Closed

git-rename-branch arguments are in wrong order #759

btmurrell opened this issue Jun 11, 2019 · 5 comments · Fixed by #767

Comments

@btmurrell
Copy link
Contributor

btmurrell commented Jun 11, 2019 •
edited
Loading

this command takes "new branch" as first arg and "old branch" as second arg. these arguments are reverse what they should be. In all cli's you should have the first argument as "the thing you have" and the second argument as "the thing you want". look at all unix commands as examples (mv, cp, ln). Also look at git-mv from git, and git-rename-remote and git-rename-tag in this project.

i know this argument inversion is a breaking change, but i think future users will appreciate it.
@spacewander
Copy link
Collaborator

@btmurrell
Would you like to submit a pull request? Thanks!

@btmurrell
Copy link
Contributor Author

@spacewander yes, I am planning to submit one -- i have one question on the docs tho -- do you have any tooling to generate the man and html docs? ronn? something else? thanks.

@spacewander
Copy link
Collaborator

@btmurrell
The docs are generated via ronn and make: https://github.com/tj/git-extras/blob/master/man/Readme.md#how-to-generate-documentation

spacewander added a commit to spacewander/git-extras that referenced this issue Jul 6, 2019
@spacewander
git-rename-branch: change branch argument order
df06f3e 
Now git-rename-branch has the same order like 'git branch -m', 'git
rename-tag' and other rename command.

Note that this is a break change.

Close tj#759.
@spacewander spacewander mentioned this issue Jul 6, 2019
Merged
@spacewander
Copy link
Collaborator

Closed as #767 is merged.

@btmurrell
Copy link
Contributor Author

Sorry @spacewander , i got busy with work, then vacation. Thanks for putting that one in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

git-rename-branch: change branch argument order spacewander/git-extras
2 participants
@btmurrell @spacewander