Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git missing using --no-merges doesn't seem to work as expected #562

Closed
nuragic opened this issue Aug 2, 2016 · 1 comment
Closed

git missing using --no-merges doesn't seem to work as expected #562

nuragic opened this issue Aug 2, 2016 · 1 comment
Assignees
Labels

Comments

@nuragic
Copy link

nuragic commented Aug 2, 2016

Hello,

I'm trying to use the git missing with the --no-merges param but it doesn't work as (at least I) expected: it returns the same list as calling it without the --no-merges param, listing all the commits including the merge ones.

I'm using git missing branch1 branch2 --no-merges.

If I try to run git missing branch2 --no-merges or git missing --no-merges branch2 it throws, respectively:

fatal: unrecognized argument: --no-merges...branch2

fatal: ambiguous argument 'branch2...--no-merges': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

I don't know if it's a bug or I've just misunderstood the command, however in the man page it says that the same parameters as git log can be used.

Thanks! 😄

@nicolaiskogheim
Copy link
Collaborator

Thank you for bringing our attention to this one. git-missing is definitely not supposed to behave like that :)

There are two bugs (that I was able to spot, at least). The first is that the two first arguments to git missing is always assumed to be branch names. The second is that arguments after that are discarded.

@nicolaiskogheim nicolaiskogheim self-assigned this Aug 6, 2016
nicolaiskogheim added a commit to nicolaiskogheim/git-extras that referenced this issue Aug 6, 2016
nicolaiskogheim added a commit to nicolaiskogheim/git-extras that referenced this issue Aug 6, 2016
nicolaiskogheim added a commit that referenced this issue Aug 6, 2016
…sing

git-missing: do proper argument parsing. Fix #562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants