Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New git-utimes is broken on Mac #1118

Closed
spacewander opened this issue Nov 21, 2023 · 1 comment · Fixed by #1119
Closed

New git-utimes is broken on Mac #1118

spacewander opened this issue Nov 21, 2023 · 1 comment · Fixed by #1119

Comments

@spacewander
Copy link
Collaborator

When I run git-utimes on Mac, I get this error:

awk: cmd. line:10: fatal: not enough arguments to satisfy format string
	` t=$(date %s$1 "+%Y%m%d%H%M.%S")
'
	                     ^ ran out for this one

CC @rasa

20231121110017
rasa added a commit to rasa/git-extras that referenced this issue Nov 21, 2023
@rasa
Fix: patch git-utimes (fixes tj#1118)
7c5dff4 
I don’t have a Mac/BSD system to test, but this should fix tj#1118
@rasa rasa mentioned this issue Nov 21, 2023
Merged
rasa added a commit to rasa/git-extras that referenced this issue Nov 21, 2023
@rasa
Fix: patch git-utimes (fixes tj#1118)
f2b0031 
Fixes tj#1118
@rasa
Copy link
Contributor

rasa commented Nov 21, 2023 •
edited
Loading

@spacewander Thanks for the catch! I didn't have a Mac to test this, but now I do, and I tested my latest commit on it and can confirm it fixes this issue. The issue was I hadn't doubled the %s in the date format string for printf.

spacewander pushed a commit that referenced this issue Nov 23, 2023
@rasa
Fix: patch git-utimes (fixes #1118) (#1119)
058cb07 
I don’t have a Mac/BSD system to test, but this should fix #1118
spacewander pushed a commit that referenced this issue Nov 23, 2023
@rasa
Fix: harden utimes, use single quotes (#1109)
e39b1ab 
* Fix: harden utimes, use single quotes

* Remove passing --posix to bash

* Remove double-quotes and backslashes

* Fix: patch git-utimes (fixes #1118)

Fixes #1118

* Fix formatting issue in git-utimes

Per #1109 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: patch git-utimes (fixes #1118) rasa/git-extras
2 participants
@rasa @spacewander