Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git standup recursive search fails if -L missing #1106

Closed
rm-- opened this issue Nov 8, 2023 · 1 comment
Closed

git standup recursive search fails if -L missing #1106

rm-- opened this issue Nov 8, 2023 · 1 comment

Comments

@rm--
Copy link
Contributor

rm-- commented Nov 8, 2023

[macOS 14.1.1, zsh, git-extras v7.1.0]

If I run git standup in a parent directory of some git-repositories.
git standup fails with:

find: : No such file or directory

If I run bash -x /usr/local/bin/git-standup, I see:

++ find '' . -maxdepth 2 -mindepth 0 -name .git
find: : No such file or directory

That's because of the quoted empty value of: $INCLUDE_LINKS in
PROJECT_DIRS=$(find "$INCLUDE_LINKS" . -maxdepth "$MAXDEPTH" -mindepth 0 -name .git)
(https://github.com/tj/git-extras/blob/main/bin/git-standup#L243)

Since $INCLUDE_LINKS is only set if -L option is used, IMO there should be a handling of the empty value or the variable should have some valid value which find can handle.
(https://github.com/tj/git-extras/blob/main/bin/git-standup#L124)

@spacewander
Copy link
Collaborator

spacewander commented Nov 10, 2023

Thanks for your analysis.
PR is welcome!

rm-- added a commit to rm--/git-extras that referenced this issue Nov 11, 2023
rm-- added a commit to rm--/git-extras that referenced this issue Nov 12, 2023
@rm-- rm-- closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants