Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe change the default ARCHIVE_NAME of git-archive-file #1067

Closed
halostatue opened this issue Sep 11, 2023 · 3 comments · Fixed by #1071
Closed

Maybe change the default ARCHIVE_NAME of git-archive-file #1067

halostatue opened this issue Sep 11, 2023 · 3 comments · Fixed by #1071

Comments

@halostatue
Copy link
Contributor

The $ARCHIVE_NAME is set to $(basename $PWD), which feels weird:

$ # This assumes that I have git-extras and the GitHub CLI installed
$ gh repo clone tj/git-extras
$ cd git-extras/man
$ git archive-file
Building archive on branch "master"
Saved to "man.3.0.0-1034-gcb29c62c65bf.master.zip" (268K)

This feels like it should instead be set to $(basename "$(git rev-parse --show-toplevel)").
@halostatue halostatue changed the title Change the default ARCHIVE_NAME of git-archive-file Maybe change the default ARCHIVE_NAME of git-archive-file Sep 11, 2023
@spacewander
Copy link
Collaborator

This change looks good to me. Would you submit a PR to change it? Thanks!

1 similar comment
@spacewander
Copy link
Collaborator

This change looks good to me. Would you submit a PR to change it? Thanks!

@halostatue halostatue mentioned this issue Sep 11, 2023
Merged
@halostatue
Copy link
Contributor Author

I didn't update the documentation for this one because the examples assumed running in the git root regardless.

spacewander pushed a commit that referenced this issue Sep 13, 2023
@halostatue
git archive-file: change base ARCHIVE_NAME (#1071)
db71be5 
Closes #1067

This makes the base ARCHIVE_NAME for `git-archive-file` to be the name
of the repo root directory instead of the name of the current directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

git archive-file: change base ARCHIVE_NAME
2 participants
@halostatue @spacewander