-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme for v7 and error management #379
Comments
Where are you seeing version 6 examples? The readme is currently matching v7 -> https://github.com/tj/connect-redis I'm haven't heard many comments recently about the FAQ question you mentioned but it does come up from time to time. |
My bad for the readme, all good. 👍 But for the faq i dont understand your point. Do you have a sample code where this code is triggered ? i tried rebooting redis server while brute forcing the express server and it never triggered this code. Feel free to close the ticket if there is nothing to do in your opinion. |
@rafipiccolo Looking at the last time this issue came up it (where we documented it), it was awhile ago and we've moved on to redis@v4 now. I'll remove it, can always readdress later, thanks for testing. |
Old and outdated questions about Redis clients where using the official client documentation is recommended. #379
Old and outdated questions about Redis clients where using the official client documentation is recommended. #379
Released in v7.0.1 |
the readme is still showing version 6 exemples.
i believe we should replace it with this : https://github.com/tj/connect-redis/releases/tag/v7.0.0
or at least add the v7 exemple since it is the actual version.
i may be wrong, but according to my tests, the last part of the readme is old / not reproducible.
"How do I handle lost connections to Redis?"
i did tests here : when redis is down middleware is hanging #373
using disableOfflineQueue and multiple versions of this lib, and this code is never called.
i would consider removing it. or adding a more reproducible code sample.
The text was updated successfully, but these errors were encountered: