Issue #346, fix collisions when option and first arg have same name #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump. |
SomeKittens
added a commit
that referenced
this pull request
Feb 26, 2015
Issue #346, fix collisions when option and first arg have same name
|
Works for me. |
This was referenced Mar 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is detailed in full in #346.
This PR has a test case demonstrates the error in the current master, and a less-than-elegant, but non-invasive way to avoid the error of conflicting action and option listeners without negatively impacting either. I am open to better solutions, but other than establishing a separate emitter for both options and actions, I don't know a better way than a naming convention (
action_prefix) to keep them from colliding, in my brief inspection anyway.