Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore extra sanity check when enabling storeOptionsAsProperties #2029

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Restore extra sanity check when enabling storeOptionsAsProperties #2029

merged 1 commit into from
Oct 13, 2023

Conversation

shadowspawn
Copy link
Collaborator

This is just enabling #1928 again, to land in a major version release.

abetomo
abetomo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit d90c59c into tj:release/12.x Oct 13, 2023
6 checks passed
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Oct 13, 2023
@shadowspawn shadowspawn deleted the feature/restore-sanity-check branch November 10, 2023 22:08
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @abetomo