Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Jest bug #2011

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

Work-around a Jest issue that shows up in recent Node.js 18 versions. Ascii colours are being included in spawned command output in certain tests. As first raised in #1950.

Reference: jestjs/jest#14391

Solution

Suppress colours in the failing tests with environment variable FORCE_COLOR.

This is a simpler version of #1950. (@aweebit added as co-author in commit comment)

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shadowspawn shadowspawn merged commit 8edcfd9 into tj:develop Sep 10, 2023
11 checks passed
@shadowspawn shadowspawn deleted the feature/work-around-jest-bug branch September 10, 2023 20:58
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Sep 10, 2023
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants