Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: typo in command example #1113

Merged
merged 2 commits into from
Dec 7, 2019
Merged

doc: typo in command example #1113

merged 2 commits into from
Dec 7, 2019

Conversation

bodinsamuel
Copy link
Contributor

  • Correct a small typo in command() example

@bodinsamuel
Copy link
Contributor Author

Not sure why it failed, seems unrelated 🙇

@shadowspawn
Copy link
Collaborator

Would you please edit your Pull Request and change the target branch to develop? Should be easy, don't go to trouble of making a new pull request if you don't see how to do it!

Normally I would accept a documentation fix directly on master, but hopefully on the develop branch we have fixed the false-positive test failures with ts-node which you hit, so I am interested to check the tests pass on develop.

Thanks for the correction.

@bodinsamuel bodinsamuel changed the base branch from master to develop December 7, 2019 13:20
@bodinsamuel
Copy link
Contributor Author

done 👌

@shadowspawn shadowspawn merged commit 3baa16f into tj:develop Dec 7, 2019
@shadowspawn
Copy link
Collaborator

Thank you for your contributions.

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Dec 11, 2019
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants