Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught Error in git-style sub-command #306

Closed
zhiyelee opened this issue Dec 13, 2014 · 0 comments
Closed

Uncaught Error in git-style sub-command #306

zhiyelee opened this issue Dec 13, 2014 · 0 comments
Labels
bug Commander is not working as intended

Comments

@zhiyelee
Copy link
Collaborator

run the examples/pm get below error:

✍ examples/pm search
module.js:333
    throw err;
          ^
Error: Cannot find module '/Users/lizhiye/dev/or/commander.js/examples/pm-search'
    at Function.Module._resolveFilename (module.js:331:15)
    at Function.Module._load (module.js:273:25)
    at Function.Module.runMain (module.js:490:10)
    at startup (node.js:124:16)
    at node.js:807:3

The error handler code do not work in https://github.com/tj/commander.js/blob/master/index.js#L459-L465
zhiyelee added a commit to zhiyelee/commander.js that referenced this issue Dec 14, 2014
@zhiyelee
solve tj#306, and bin in $PATH make sense now
6c33af8 
Almost revert tj#173 which lead to the bug in tj#306
@zhiyelee zhiyelee mentioned this issue Dec 14, 2014
Closed
@zhiyelee zhiyelee added bug Commander is not working as intended help wanted labels Dec 23, 2014
zhiyelee added a commit to zhiyelee/commander.js that referenced this issue Jan 8, 2015
@zhiyelee
solve tj#306, and bin in $PATH make sense now
c936e47 
Almost revert tj#173 which lead to the bug in tj#306
zhiyelee added a commit to zhiyelee/commander.js that referenced this issue Jan 10, 2015
@zhiyelee
solve tj#306, and bin in $PATH make sense
154fb8b 
solve tj#306, and bin in $PATH make sense now tj#196
Almost revert tj#173 which lead to the bug in tj#306

Also remove deprecated customFds option in spawn
@zhiyelee zhiyelee mentioned this issue Jan 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Commander is not working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhiyelee @shadowspawn