Skip to content

Commit

Permalink
Comment out new misuse check until a major version
Browse files Browse the repository at this point in the history
  • Loading branch information
shadowspawn committed Oct 7, 2023
1 parent 96c6c25 commit a0f541a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions lib/command.js
Original file line number Diff line number Diff line change
Expand Up @@ -751,9 +751,9 @@ Expecting one of '${allowedValues.join("', '")}'`);
if (this.options.length) {
throw new Error('call .storeOptionsAsProperties() before adding options');
}
if (Object.keys(this._optionValues).length) {
throw new Error('call .storeOptionsAsProperties() before setting option values');
}
// if (Object.keys(this._optionValues).length) {
// throw new Error('call .storeOptionsAsProperties() before setting option values');
// }
this._storeOptionsAsProperties = !!storeAsProperties;
return this;
}
Expand Down
14 changes: 7 additions & 7 deletions tests/commander.configureCommand.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ test('when storeOptionsAsProperties() after adding option then throw', () => {
}).toThrow();
});

test('when storeOptionsAsProperties() after setting option value then throw', () => {
const program = new commander.Command();
program.setOptionValue('foo', 'bar');
expect(() => {
program.storeOptionsAsProperties();
}).toThrow();
});
// test('when storeOptionsAsProperties() after setting option value then throw', () => {

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 16.x and ubuntu-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 16.x and windows-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 16.x and macos-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 18.x and ubuntu-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 18.x and windows-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 18.x and macos-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 20.x and ubuntu-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 20.x and windows-latest

Some tests seem to be commented

Check warning on line 88 in tests/commander.configureCommand.test.js

View workflow job for this annotation

GitHub Actions / Test on node 20.x and macos-latest

Some tests seem to be commented
// const program = new commander.Command();
// program.setOptionValue('foo', 'bar');
// expect(() => {
// program.storeOptionsAsProperties();
// }).toThrow();
// });

0 comments on commit a0f541a

Please sign in to comment.