Ponyfill Promise with pinkie-promise #250
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative way to support Node.js 0.10 (see #244).
We are using
co
in ava test framework and polyfilling global Promise object is not working for us, because it will affect code under testing. If code under testing relies on Promise object and we polyfill it globally it will pass tests on Node.js 0.10, but will fail in production.This approach supports polyfilling global Promise with
global.Promise = require('bluebird');
and returns native promises (if available). If neither works it will return small pinkie polyfill.