String literals need to be inside single-quotes #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://docs.github.com/en/actions/learn-github-actions/expressions#literals string You must use single quotes. Escape literal single-quotes with a single quote.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This is a documentation change. I don't know how to create a test for it. Is this the right way to modify the README.md, or is there another way that this should be done? |
|
@wushujames Thanks for updating the README.md, you don't have to include any test for your changes. Looks good. 👍 |
|
@all-contributors please add @wushujames for docs |
|
I've put up a pull request to add @wushujames! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://docs.github.com/en/actions/learn-github-actions/expressions#literals
string You must use single quotes. Escape literal single-quotes with a single quote.