Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix for Csv.toFrame bug #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

darrenjw
Copy link

This PR introduces a test illustrating the bug in Csv.toFrame (Issue #64), and a possible fix for it.

@tixxit
Copy link
Owner

tixxit commented Nov 26, 2015

Thanks for this! The fix seems to work, but I'm a little concerned about doing an extraction per row with Rows vs the more batch-able Cols approach (for performance reasons). I'll take a look though and see if there is anything we can do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants