Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs에서 global style이 로드되지 않는 문제 해결 #360

Merged
merged 2 commits into from
Dec 26, 2019
Merged

docs에서 global style이 로드되지 않는 문제 해결 #360

merged 2 commits into from
Dec 26, 2019

Conversation

inbeom
Copy link
Contributor

@inbeom inbeom commented Dec 26, 2019

설명

styled-components 버전업에 따라 달라진 global style 로드 방식을 docs에 적용합니다.

참고

변경 내역 및 배경

  • Storybook의 decorator를 활용해 GlobalStyle 컴포넌트를 마운트합니다.

사용 및 테스트 방법

docs 실행

스크린샷

이 PR의 유형

  • 버그 또는 사소한 수정
  • 기능 추가 (하위 호환을 유지하면서 기능을 추가합니다.)
  • Breaking change (관련 컴포넌트를 기존에 사용하던 곳들에 코드 수정이 필요합니다.)

체크리스트

  • 기능 추가 및 breaking change에 대한 CHANGELOG를 추가했습니다.
  • docs의 스토리를 변경했습니다.

@inbeom inbeom requested a review from a team as a code owner December 26, 2019 08:51
appear
appear approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@appear appear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헠 .. 이게 빠졌었군요 ... :gg:

@appear appear requested a review from a team December 26, 2019 09:00
luffy-song
luffy-song approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@luffy-song luffy-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:gg:

@inbeom inbeom merged commit 6f34a08 into master Dec 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/global-style-load branch December 26, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luffy-song luffy-song luffy-song approved these changes

@appear appear appear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inbeom @appear @luffy-song