Feature/qol fixes #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Initial OSS Release (#1)
Signed-off-by: Derek Smart <[email protected]>
Github Actions with minor fixes (#11)
update from fork
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
Signed-off-by: Derek Smart <[email protected]>
mcred
force-pushed
the
feature/qol-fixes
branch
from
81f92e2 to
481c86c
Compare
eschrock
approved these changes
Sep 26, 2019
mcred
referenced
this pull request
in mcred/titan
Oct 29, 2019
mcred
referenced
this pull request
in mcred/titan
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Fixes #4
Fixes #5
Fixes #7
Fixes #8
Top level error handling and exception catching.
Proposed Changes
Describe your proposed changes. Focus on providing additional context that
may not be visible in the code itself. Why did you take the approach that you
did? What other approaches were considered? If this is a complex change,
provide some architectural context so reviewers understand how the pieces
fit together.
Testing
Test error handing by running any command with the docker machine not running.
Test #4
titan clone s3://titan-WTF/some-dataTest #5
titan clone s3://titan-data-cto/engdemoand then
titan clone s3://titan-data-cto/engdemoTest #7
titan clone s3://titan-data-cto/engdemodocker rm engdemo -ftitan lsTest #8
titan uninstall -fdocker rmi *titan:latest* -fget image ID to remove all aliasestitan install -r someregistry