Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing v1.2.0 #10

Merged
merged 37 commits into from
Jan 9, 2025
Merged

Releasing v1.2.0 #10

merged 37 commits into from
Jan 9, 2025

Conversation

pysco68
Copy link
Contributor

@pysco68 pysco68 commented Jan 9, 2025

This contains:

  • improved test suite
  • a slew of fixes discovered during the implementation of the test suite (race conditions and others)
  • fixes for --no-timeout
  • fixes for docker-to-docker permissions scenarios

pysco68 and others added 30 commits December 17, 2024 16:00
@pysco68
🔧 added first run of tests
0168e93
@pysco68
🔧 fixed version gen showing git tag instead of commit hash if present
1e4e4cd
@pysco68
🔧 fixed racy read from goldilock_spot file
e63f57b
@pysco68
🔧 fixing concurrent read/write bug in list_lockfile_spots() and updat…
b77c5ca 
…e_spot()
@pysco68
🔧 added test case for multiple lock files
caa9bcc
@pysco68
🔧 implemented test for parent process watching
c6999f8
@pysco68
🔧 added a test for goldilock signal handling robustness
1677320
@pysco68
🔧 reproduced the fix for ignoring SIGCHLD when spawning the detached …
2440385 
…goldilock
@pysco68
🔧 enabling testing in the CI
ebe44e7
@pysco68
🔧 typo in linux ci test execution
624aaac
@pysco68
🔧 linux ci needs tipi run for ctest
84bb64b
@Lambourl
🔧 truncate on macos
078dac9
@Lambourl
🔧 lets RAII do clear and delete maps
c9010fd
@pysco68
🔧 added daemonizing capabilities to support_app_launcher to solve SIG…
a39f0ea 
…CHLD issues and ensured that the CI is starting the docker container with an init process that reaps (detached) child processes to not have leftover zombies
@pysco68
🔧 remaining review points
6adae07
@Lambourl
🔧 change request by code reviews
6b7cf07
@pysco68
Merge pull request #9 from tipi-build/feature/fix-macos-test
bf9cee7 
Fixed tests and goldilock on macOS
@pysco68
🔧 ensuring all (relevant) tests work on windows too
6ba7ad1
@pysco68
🔧 shell of the docker tests
75522d2
@pysco68
🔧 enabling docker test on linux CI
9c8208c
@pysco68
🔧 fix docker command/process launch issue in CI
124f70a
@pysco68
🔧 added a more complex goldilock in docker test case that makes us of…
a73b7d5 
… most features
@pysco68
🔧 the signal robustness test is currently linux/macos only
1b6c785
@pysco68
🔧 solved multi-user permission issues on lockfiles and improved high …
12f4c20 
…concurrency lock grabbing
@pysco68
🔧 added a small benchmark - like test
da4e0ee
@pysco68
🧹 cleanup
d0c55f1
@pysco68
🔧 fixed missing include on windows and benchmark overwhelming the low…
3b6dacd 
…er core count machines in the CI
@pysco68
🔧 debugging flaky test on CI
1c16118
@pysco68
🔧 fixing const err on state variable in benchmark
9ba06f1
@pysco68
🔧 Fixing docker-in-docker path impedance between GH actions and local…
92216aa 
… execution
@pysco68 pysco68 requested a review from daminetreg January 9, 2025 15:54
@daminetreg daminetreg merged commit 5b34d2f into main Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminetreg daminetreg Awaiting requested review from daminetreg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pysco68 @daminetreg @Lambourl