Slack vitess 9 2021.03.16r0

.github/CODEOWNERS

@@ -1,20 +1,36 @@
 * @sougou
 
+/config/mycnf/ @askdba @shlomi-noach
 /docker/ @derekperkins @dkhenry
-/helm/ @derekperkins @dkhenry
-/config/mycnf/ @morgo
-/go/vt/mysqlctl/mysqld.go @morgo
+/examples/compose @shlomi-noach
+/examples/local @rohit-nayak-ps
+/go/cmd/vtadmin @ajm188 @doeg
+/go/cmd/vtctldclient @ajm188 @doeg
+/go/mysql @harshit-gangal @systay
+/go/test/endtoend/onlineddl @shlomi-noach
+/go/test/endtoend/orchestrator @deepthi @shlomi-noach
 /go/test/endtoend/vtgate @harshit-gangal @systay
-/go/vt/vtgate @harshit-gangal @systay
-/go/vt/vttablet/tabletserver @harshit-gangal @systay
-/go/vt/vttablet/tabletmanager/vstreamer @rohit-nayak-ps
-/go/vt/sqlparser @harshit-gangal @systay
 /go/vt/discovery @deepthi
-/go/vt/vttablet/tabletmanager @deepthi
-/go/vt/vttablet/tabletmanager/vreplication @rohit-nayak-ps
-/go/vt/orchestrator @deepthi
+/go/vt/mysqlctl @deepthi
+/go/vt/proto/vtadmin @ajm188 @doeg
+/go/vt/orchestrator @deepthi @shlomi-noach
+/go/vt/schema @shlomi-noach
+/go/vt/sqlparser @harshit-gangal @systay
+/go/vt/vtadmin @ajm188 @doeg
 /go/vt/vtctl @deepthi
+/go/vt/vtctl/vtctl.go @ajm188 @doeg
+/go/vt/vtctl/grpcvtctldclient @ajm188 @doeg
+/go/vt/vtctl/grpcvtctldserver @ajm188 @doeg
+/go/vt/vtctl/vtctldclient @ajm188 @doeg
+/go/vt/vtgate @harshit-gangal @systay
+/go/vt/vttablet/tabletmanager @deepthi @shlomi-noach
+/go/vt/vttablet/tabletmanager/vreplication @rohit-nayak-ps
+/go/vt/vttablet/tabletmanager/vstreamer @rohit-nayak-ps
+/go/vt/vttablet/tabletserver @harshit-gangal @systay @shlomi-noach
 /go/vt/wrangler @deepthi @rohit-nayak-ps
-/go/vt/mysqlctl @deepthi
+/helm/ @derekperkins @dkhenry
+/proto/vtadmin.proto @ajm188 @doeg
+/proto/vtctldata.proto @ajm188 @doeg
+/proto/vtctlservice.proto @ajm188 @doeg
+/web/vtadmin @ajm188 @doeg
 /web/vtctld2 @rohit-nayak-ps
-/examples/local @rohit-nayak-ps

.github/pull_request_template.md

@@ -0,0 +1,25 @@
+<!-- if this PR is Work in Progress please create it as a Draft Pull Request -->
+
+## Description
+<!-- A few sentences describing the overall goals of the pull request's commits. -->
+
+## Related Issue(s)
+<!-- List related issues and pull requests: -->
+
+- 
+
+## Checklist
+- [ ] Should this PR be backported?
+- [ ] Tests were added or are not required
+- [ ] Documentation was added or is not required
+
+## Deployment Notes
+<!-- Notes regarding deployment of the contained body of work. These should note any db migrations, etc. -->
+
+## Impacted Areas in Vitess
+Components that this PR will affect:
+
+- [ ]  Query Serving
+- [ ]  VReplication
+- [ ]  Cluster Management
+- [ ]  Build 

.github/workflows/check_formatting.yml

@@ -10,7 +10,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/check_make_parser.yml

@@ -10,7 +10,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/check_make_visitor.yml

@@ -10,7 +10,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/cluster_endtoend.yml

@@ -12,7 +12,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/cluster_endtoend_upgrade.yml

@@ -0,0 +1,105 @@
+name: Cluster (upgrade)
+on: [push, pull_request]
+jobs:
+
+  build:
+    name: Run endtoend tests on Cluster (upgrade)
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: 1.15
+
+    - name: Check out v8.0.0
+      uses: actions/checkout@v2
+      with:
+        ref: v8.0.0
+
+    - name: Get dependencies
+      run: |
+        # This prepares general purpose binary dependencies
+        # as well as v8.0.0 specific go modules
+        sudo apt-get update
+        sudo apt-get install -y mysql-server mysql-client make unzip g++ etcd curl git wget eatmydata
+        sudo service mysql stop
+        sudo service etcd stop
+        sudo ln -s /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/
+        sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
+        go mod download
+
+        wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
+        sudo apt-get install -y gnupg2
+        sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
+        sudo apt-get update
+        sudo apt-get install percona-xtrabackup-24
+
+    - name: Building v8.0.0 binaries
+      timeout-minutes: 10
+      run: |
+        # We build v8.0.0 binaries and save them in a temporary location
+        source build.env
+        make build
+        mkdir -p /tmp/vitess-build-v8.0.0/
+        cp -R bin /tmp/vitess-build-v8.0.0/
+
+    - name: Check out HEAD
+      uses: actions/checkout@v2
+
+    - name: Run cluster endtoend test v8.0.0 (create cluster)
+      timeout-minutes: 5
+      run: |
+        # By checking out we deleted bin/ directory. We now restore our pre-built v8.0.0 binaries
+        cp -R /tmp/vitess-build-v8.0.0/bin .
+        # create the directory where we store test data; ensure it is empty:
+        rm -rf /tmp/vtdataroot
+        mkdir -p /tmp/vtdataroot
+        source build.env
+        # We pass -skip-build so that we use the v8.0.0 binaries, not HEAD binaries
+        eatmydata -- go run test.go -skip-build -keep-data -docker=false -print-log -follow -shard 28
+
+    - name: Check out HEAD
+      uses: actions/checkout@v2
+
+
+    - name: Building HEAD binaries
+      timeout-minutes: 10
+      run: |
+        go mod download
+
+        source build.env
+        make build
+        mkdir -p /tmp/vitess-build-head/
+        cp -R bin /tmp/vitess-build-head/
+
+    - name: Run cluster endtoend test HEAD based on v8.0.0 data (upgrade path)
+      timeout-minutes: 5
+      run: |
+        # /tmp/vtdataroot exists from previous test
+
+        source build.env
+        # We built HEAD binaries manually in previous step and there's no need for the test to build.
+        eatmydata -- go run test.go -skip-build -keep-data -docker=false -print-log -follow -shard 28
+
+    - name: Run cluster endtoend test HEAD (create cluster)
+      timeout-minutes: 5
+      run: |
+        # create the directory where we store test data; ensure it is empty:
+        rm -rf /tmp/vtdataroot
+        mkdir -p /tmp/vtdataroot
+
+        source build.env
+        # We still have the binaries from previous step. No need to build
+        eatmydata -- go run test.go -skip-build -keep-data -docker=false -print-log -follow -shard 28
+
+
+    - name: Run cluster endtoend test v8.0.0 based on HEAD data (downgrade path)
+      timeout-minutes: 5
+      run: |
+        # /tmp/vtdataroot exists from previous test
+        cp -R /tmp/vitess-build-v8.0.0/bin .
+
+        source build.env
+        # We again built manually and there's no need for the test to build.
+        eatmydata -- go run test.go -skip-build -keep-data -docker=false -print-log -follow -shard 28

.github/workflows/cluster_initial_sharding_multi.yml

@@ -10,11 +10,11 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2
 
     - name: Run initial sharding multi
       run: |
-        go run test.go -print-log initial_sharding_multi
+        go run test.go -print-log initial_sharding_multi

.github/workflows/create_release.yml

@@ -16,7 +16,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/e2e_race.yml

@@ -10,7 +10,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/endtoend.yml

@@ -10,7 +10,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/ensure_bootstrap_updated.yml

@@ -0,0 +1,22 @@
+name: ensure_bootstrap_version
+on: [pull_request]
+jobs:
+
+  build:
+    name: Check Bootstrap Updated
+    runs-on: ubuntu-latest
+    steps:
+
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: 1.13
+
+    - name: Check out code
+      uses: actions/checkout@v2
+
+    - name: run ensure_bootstrap_version
+      run: |
+        make ensure_bootstrap_version
+        git status
+        test -z "$(git diff-index --name-only HEAD --)" || exit 1

.github/workflows/golangci-linter.yml

@@ -1,23 +1,27 @@
 name: golangci-lint
-on: [push,pull_request]
+on: [push, pull_request]
 jobs:
-
   build:
     name: Build
     runs-on: ubuntu-latest
     steps:
+      - name: Set up Go 1.15
+        uses: actions/setup-go@v1
+        with:
+          go-version: 1.15
+        id: go
+
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v1
 
-    - name: Set up Go 1.13
-      uses: actions/setup-go@v1
-      with:
-        go-version: 1.13
-      id: go
+      - name: Install golangci-lint
+        run: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(go env GOPATH)/bin v1.31.0
 
-    - name: Check out code into the Go module directory
-      uses: actions/checkout@v1
+      - name: Clean Env
+        run: $(go env GOPATH)/bin/golangci-lint cache clean
 
-    - name: Install golangci-lint
-      run: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(go env GOPATH)/bin v1.27.0
+      - name: Print linter version
+        run: $(go env GOPATH)/bin/golangci-lint --version
 
-    - name: Run golangci-lint
-      run: $(go env GOPATH)/bin/golangci-lint run --disable=errcheck --timeout=10m go/...
+      - name: Run golangci-lint
+        run: $(go env GOPATH)/bin/golangci-lint run go/...

.github/workflows/legacy_local_example.yml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/local_example.yml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/region_example.yml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/unit.yml

@@ -12,7 +12,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.github/workflows/unit_race.yml

@@ -10,7 +10,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.13
+        go-version: 1.15
 
     - name: Check out code
       uses: actions/checkout@v2

.golangci.yml

@@ -0,0 +1,28 @@
+run:
+  timeout: 10m
+
+linters-settings:
+  goimports:
+    local-prefixes: vitess.io/vitess
+
+linters:
+  disable-all: true
+  enable:
+    # Defaults
+    - deadcode
+    # - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - structcheck
+    - typecheck
+    - varcheck
+
+    # Extras
+    - gofmt
+    - goimports
+
+# https://github.com/golangci/golangci/wiki/Configuration
+service:
+  golangci-lint-version: 1.31.0 # use the fixed version to not introduce new linters unexpectedly