Merge pull request vitessio#7420 from tinyspeck/am_extract_repl_pos_s…

…earcher Extract the `maxReplPosSearch` struct out to `topotools`
tinyspeck · Mar 8, 2021 · c532bf9 · c532bf9
1 parent f8a19a5
commit c532bf9
Show file tree

Hide file tree

Showing 3 changed files with 363 additions and 51 deletions.
diff --git a/go/vt/topotools/position_searcher.go b/go/vt/topotools/position_searcher.go
@@ -0,0 +1,124 @@
+/*
+Copyright 2021 The Vitess Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+	http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package topotools
+
+import (
+	"context"
+	"sync"
+	"time"
+
+	"vitess.io/vitess/go/mysql"
+	"vitess.io/vitess/go/vt/logutil"
+	"vitess.io/vitess/go/vt/topo/topoproto"
+	"vitess.io/vitess/go/vt/vttablet/tmclient"
+
+	topodatapb "vitess.io/vitess/go/vt/proto/topodata"
+)
+
+// MaxReplicationPositionSearcher provides a threadsafe way to find a tablet
+// with the most advanced replication position.
+//
+// A typical usage will look like:
+//
+//		var (
+//			searcher = NewMaxReplicationPositionSearcher(tmc, logger, waitTimeout)
+//			wg sync.WaitGroup
+//		)
+//		for _, tablet := range tablets {
+//			wg.Add(1)
+//			go func(t *topodatapb.Tablet) {
+//				defer wg.Done()
+//				searcher.ProcessTablet(ctx, t)
+//			}(tablet)
+//		}
+//		wg.Wait()
+//		maxPosTablet := searcher.MaxPositionTablet()
+//
+type MaxReplicationPositionSearcher struct {
+	tmc         tmclient.TabletManagerClient
+	logger      logutil.Logger
+	waitTimeout time.Duration
+	m           sync.Mutex
+
+	maxPos       mysql.Position
+	maxPosTablet *topodatapb.Tablet
+}
+
+// NewMaxReplicationPositionSearcher returns a new
+// MaxReplicationPositionSearcher instance, ready to begin processing tablets.
+// To reuse an existing instance, first call Reset().
+func NewMaxReplicationPositionSearcher(tmc tmclient.TabletManagerClient, logger logutil.Logger, waitTimeout time.Duration) *MaxReplicationPositionSearcher {
+	return &MaxReplicationPositionSearcher{
+		tmc:          tmc,
+		logger:       logger,
+		waitTimeout:  waitTimeout,
+		m:            sync.Mutex{},
+		maxPos:       mysql.Position{},
+		maxPosTablet: nil,
+	}
+}
+
+// ProcessTablet processes the replication position for a single tablet and
+// updates the state of the searcher. It is safe to call from multiple
+// goroutines.
+func (searcher *MaxReplicationPositionSearcher) ProcessTablet(ctx context.Context, tablet *topodatapb.Tablet) {
+	searcher.logger.Infof("getting replication position from %v", topoproto.TabletAliasString(tablet.Alias))
+
+	ctx, cancel := context.WithTimeout(ctx, searcher.waitTimeout)
+	defer cancel()
+
+	status, err := searcher.tmc.ReplicationStatus(ctx, tablet)
+	if err != nil {
+		searcher.logger.Warningf("failed to get replication status from %v, ignoring tablet: %v", topoproto.TabletAliasString(tablet.Alias), err)
+
+		return
+	}
+
+	pos, err := mysql.DecodePosition(status.Position)
+	if err != nil {
+		searcher.logger.Warningf("cannot decode replica position %v for tablet %v, ignoring tablet: %v", status.Position, topoproto.TabletAliasString(tablet.Alias), err)
+
+		return
+	}
+
+	searcher.m.Lock()
+	defer searcher.m.Unlock()
+
+	if searcher.maxPosTablet == nil || !searcher.maxPos.AtLeast(pos) {
+		searcher.maxPos = pos
+		searcher.maxPosTablet = tablet
+	}
+}
+
+// MaxPositionTablet returns the most advanced-positioned tablet the searcher
+// has seen so far.
+func (searcher *MaxReplicationPositionSearcher) MaxPositionTablet() *topodatapb.Tablet {
+	searcher.m.Lock()
+	defer searcher.m.Unlock()
+
+	return searcher.maxPosTablet
+}
+
+// Reset clears any tracked position or tablet from the searcher, making this
+// instance ready to begin a new search.
+func (searcher *MaxReplicationPositionSearcher) Reset() {
+	searcher.m.Lock()
+	defer searcher.m.Unlock()
+
+	searcher.maxPos = mysql.Position{}
+	searcher.maxPosTablet = nil
+}
diff --git a/go/vt/topotools/position_searcher_test.go b/go/vt/topotools/position_searcher_test.go
@@ -0,0 +1,223 @@
+package topotools
+
+import (
+	"context"
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+
+	"vitess.io/vitess/go/vt/logutil"
+	"vitess.io/vitess/go/vt/topo/topoproto"
+	"vitess.io/vitess/go/vt/vttablet/tmclient"
+
+	replicationdatapb "vitess.io/vitess/go/vt/proto/replicationdata"
+	topodatapb "vitess.io/vitess/go/vt/proto/topodata"
+)
+
+type fakeTMClient struct {
+	tmclient.TabletManagerClient
+	tabletReplicationPositions map[string]*replicationdatapb.Status
+}
+
+func (fake *fakeTMClient) ReplicationStatus(ctx context.Context, tablet *topodatapb.Tablet) (*replicationdatapb.Status, error) {
+	if fake.tabletReplicationPositions == nil {
+		return nil, assert.AnError
+	}
+
+	if tablet.Alias == nil {
+		return nil, assert.AnError
+	}
+
+	if pos, ok := fake.tabletReplicationPositions[topoproto.TabletAliasString(tablet.Alias)]; ok {
+		return pos, nil
+	}
+
+	return nil, assert.AnError
+}
+
+func TestMaxReplicationPositionSearcher(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name      string
+		positions map[string]*replicationdatapb.Status
+		tablets   []*topodatapb.Tablet
+		expected  *topodatapb.Tablet
+	}{
+		{
+			name: "success",
+			positions: map[string]*replicationdatapb.Status{
+				"zone1-0000000100": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23",
+				},
+				"zone1-0000000101": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23-28",
+				},
+				"zone1-0000000102": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23-30",
+				},
+			},
+			tablets: []*topodatapb.Tablet{
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  100,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  101,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  102,
+					},
+				},
+			},
+			expected: &topodatapb.Tablet{
+				Alias: &topodatapb.TabletAlias{
+					Cell: "zone1",
+					Uid:  102,
+				},
+			},
+		},
+		{
+			name: "reverse order",
+			positions: map[string]*replicationdatapb.Status{
+				"zone1-0000000100": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23",
+				},
+				"zone1-0000000101": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23-28",
+				},
+				"zone1-0000000102": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23-30",
+				},
+			},
+			tablets: []*topodatapb.Tablet{
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  102,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  101,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  100,
+					},
+				},
+			},
+			expected: &topodatapb.Tablet{
+				Alias: &topodatapb.TabletAlias{
+					Cell: "zone1",
+					Uid:  102,
+				},
+			},
+		},
+		{
+			name: "no position for tablet is ignored",
+			positions: map[string]*replicationdatapb.Status{
+				"zone1-0000000100": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23",
+				},
+			},
+			tablets: []*topodatapb.Tablet{
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  100,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  101,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  102,
+					},
+				},
+			},
+			expected: &topodatapb.Tablet{
+				Alias: &topodatapb.TabletAlias{
+					Cell: "zone1",
+					Uid:  100,
+				},
+			},
+		},
+		{
+			name: "bad position is ignored",
+			positions: map[string]*replicationdatapb.Status{
+				"zone1-0000000100": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23",
+				},
+				"zone1-0000000101": {
+					Position: "MySQL56/3E11FA47-71CA-11E1-9E33-C80AA9429562:23-28",
+				},
+				"zone1-0000000102": {
+					Position: "junk position",
+				},
+			},
+			tablets: []*topodatapb.Tablet{
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  100,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  101,
+					},
+				},
+				{
+					Alias: &topodatapb.TabletAlias{
+						Cell: "zone1",
+						Uid:  102,
+					},
+				},
+			},
+			expected: &topodatapb.Tablet{
+				Alias: &topodatapb.TabletAlias{
+					Cell: "zone1",
+					Uid:  101,
+				},
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		tt := tt
+
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
+			ctx := context.Background()
+			tmc := &fakeTMClient{
+				tabletReplicationPositions: tt.positions,
+			}
+			searcher := NewMaxReplicationPositionSearcher(tmc, logutil.NewMemoryLogger(), time.Millisecond*50)
+
+			for _, tablet := range tt.tablets {
+				searcher.ProcessTablet(ctx, tablet)
+			}
+
+			assert.Equal(t, tt.expected, searcher.MaxPositionTablet())
+		})
+	}
+}