This repository has been archived by the owner on Aug 21, 2020. It is now read-only.
Fix the PSpellEngine getSuggestions function #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stions, only checking words)
| $outWords[$word] = array(); | ||
|
|
||
| foreach( pspell_suggest($plink, trim($word)) as $suggestedWord ) { | ||
| $outWords[$word][] = utf8_encode($suggestedWord); |
There was a problem hiding this comment.
If pspell already outputs utf-8 things will be double encoded, resulting in broken output
There was a problem hiding this comment.
Thanks, i'll look into a proper fix for it soon
|
This GitHub repository contains the server-side code for the TinyMCE Community SpellChecker Plugin. This plugin was deprecated with the release of TinyMCE 5.4. No more development will be done on this plugin, and we are closing all associated pull requests. For more information, please see: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getSuggestions function wasn't returning any suggestions, only which words had been misspelt