Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for variables in the configuration file #115

Merged
merged 3 commits into from
Aug 4, 2019
Merged

Add default values for variables in the configuration file #115

merged 3 commits into from
Aug 4, 2019

Conversation

simonsilvalauinger
Copy link
Contributor

implements #112

@pmwmedia
Copy link
Member

Thank you very much for your pull request! Code looks clean and self explaining :-) I really appreciate that you have also supplied unit tests!

Just a minor change request: tinylog has to be compatible with Java 1.6 to support Android as well. Could refactor your code to avoid using an Optional, which was introduced with Java 1.8.

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #115 into v2.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##               v2.0     #115      +/-   ##
============================================
+ Coverage     94.84%   94.85%   +<.01%     
- Complexity     2187     2190       +3     
============================================
  Files           103      103              
  Lines          4153     4161       +8     
  Branches        416      419       +3     
============================================
+ Hits           3939     3947       +8     
  Misses          108      108              
  Partials        106      106
Impacted Files Coverage Δ Complexity Δ
.../java/org/tinylog/configuration/Configuration.java 100% <100%> (ø) 30 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abc948...40a7309. Read the comment docs.

@pmwmedia
Copy link
Member

Thank you very much! I will open a branch for tinylog 2.1 soon and merge your pull request.

@pmwmedia pmwmedia changed the base branch from v2.0 to v2.1 August 4, 2019 18:30
@pmwmedia pmwmedia merged commit c3596ea into tinylog-org:v2.1 Aug 4, 2019
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

This closed pull request has been locked automatically. However, please feel free to file an issue or create a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants