fix: ensure that minThreads is respected when using isolateWorkers
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
AriPerkkio
reviewed
Jun 16, 2023
AriPerkkio
approved these changes
Jun 17, 2023
|
@danez @AriPerkkio Thank you so much, guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when using
isolateWorkers: true,minThreadsis not respected correctly.After every worker run the worker is terminated, but no new workers are started unless the task-queue is bigger than the worker count.
This fix ensures that after a worker is terminated we ensure that we have the minimum amount of workers running.
Let me know what you think about this. :)