feat: workerId #30
Merged
feat: workerId #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sheremet-va couldn't put you in the reviewers! |
sheremet-va
requested changes
Jun 22, 2022
src/index.ts
Outdated
| @@ -807,7 +836,7 @@ class ThreadPool { | |||
| taskInfo.workerInfo.taskInfos.delete(taskInfo.taskId) | |||
| if (!taskInfo.workerInfo.taskInfos.size) { | |||
| this._removeWorker(taskInfo.workerInfo) | |||
| this._ensureMaximumWorkers() | |||
| // this._ensureMaximumWorkers() | |||
There was a problem hiding this comment.
Yes, we should not spawn workers, we should let the scheduler figures it out!
| export * from './common' | ||
| export { Tinypool, Options } | ||
| export { Tinypool, Options, _workerId as workerId } |
There was a problem hiding this comment.
So, the only way I can get worker id is by importing tinypool inside a script that is running in a worker? Like this:
import { workerId } from 'tinypool'There was a problem hiding this comment.
or accessing process.__tinypool_state__?.workerId
|
Also some tests are failing |
|
Maybe we also need to remove v17 and add v18 for ci tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve this vitest issue where pool id can be greater than
maxThreads! Therefore I'm implementing theworkerIdwhich would be generated for each worker and will not be greater thanmaxThreadsIt can be imported from
tinypoolasworkerIdin the worker when running!