Skip to content

Commit

Permalink
nRF52: set SPI TX/RX lengths even data is empty. Fixes #3868 (#3877)
Browse files Browse the repository at this point in the history
machine/hrf: Set SPI TX/RX lengths even data is empty. Fixes #3868
  • Loading branch information
perttierkkila authored Aug 24, 2023
1 parent e3bc6da commit 806498f
Showing 1 changed file with 17 additions and 14 deletions.
31 changes: 17 additions & 14 deletions src/machine/machine_nrf52xxx.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,24 +288,27 @@ func (spi SPI) Tx(w, r []byte) error {
// supported.
for len(r) != 0 || len(w) != 0 {
// Prepare the SPI transfer: set the DMA pointers and lengths.
if len(r) != 0 {
spi.Bus.RXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&r[0]))))
n := uint32(len(r))
if n > 255 {
n = 255
// read buffer
nr := uint32(len(r))
if nr > 0 {
if nr > 255 {
nr = 255
}
spi.Bus.RXD.MAXCNT.Set(n)
r = r[n:]
spi.Bus.RXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&r[0]))))
r = r[nr:]
}
if len(w) != 0 {
spi.Bus.TXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&w[0]))))
n := uint32(len(w))
if n > 255 {
n = 255
spi.Bus.RXD.MAXCNT.Set(nr)

// write buffer
nw := uint32(len(w))
if nw > 0 {
if nw > 255 {
nw = 255
}
spi.Bus.TXD.MAXCNT.Set(n)
w = w[n:]
spi.Bus.TXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&w[0]))))
w = w[nw:]
}
spi.Bus.TXD.MAXCNT.Set(nw)

// Do the transfer.
// Note: this can be improved by not waiting until the transfer is
Expand Down

0 comments on commit 806498f

Please sign in to comment.