hci: contains several corrections needed for HCI on both ninafw and cyw43439 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadprogram
force-pushed
the
hci-buffer-fix
branch
from
6acad81 to
2ed4eaa
Compare
|
Thanks! Examples work on the Nano 33 IoT with these changes. |
jsoriano
reviewed
Nov 17, 2024
…yw43439 * separate read and write buffers to accomodate read buffer with pending partial data to be handled * only read when there is data pending to avoid putting cwy43439 into forever loop * handle any data in buffer from read that contains data from more than 1 packet * skip past data for sync packets since we do not handle them anyhow * some better naming and comments to hopefully clarify a bit what is going on Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
hci-buffer-fix
branch
from
2ed4eaa to
55bb7c1
Compare
|
Thanks so much for this fix! I was unable to enable the bluetooth adapter on my Arduino Nano 33 IoT. But after updating to your commit in my |
|
Thanks for review/testing @jsoriano and @colececil now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several corrections needed for HCI to work correctly on both ninafw and cyw43439:
Addresses #300