Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSSI naming #272

Closed
elgohr opened this issue May 21, 2024 · 2 comments · Fixed by #273
Closed

RSSI naming #272

elgohr opened this issue May 21, 2024 · 2 comments · Fixed by #273

Comments

@elgohr
Copy link
Contributor

elgohr commented May 21, 2024

Is the description of

// RSSI the last time a packet from this device has been received.
correctly?
In other contexts RSSI stands for Received Signal Strength Indicator, which would be the strength of the signal received.
When I see it correctly this is also what is implemented - isn't it?

@aykevl
Copy link
Member

aykevl commented May 21, 2024

The comment is perhaps a bit confusing. Every incoming advertisement packet can have a different RSSI value (due to noise, change in distance, people moving around, etc) so this value the RSSI value from the last received packet.
Perhaps a better comment would be:

// The RSSI value of the received advertisement packet.

@elgohr
Copy link
Contributor Author

elgohr commented May 21, 2024

I would go for Signal strength of the advertisement packet..

Otherwise we explain RSSI with RSSI...

elgohr added a commit to elgohr/bluetooth that referenced this issue May 21, 2024
aykevl pushed a commit that referenced this issue May 21, 2024
aykevl pushed a commit that referenced this issue May 21, 2024
AndyRN pushed a commit to jasday/bluetooth that referenced this issue Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants