Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iTerm2 scripts as Applescript files #8

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bezhermoso
Copy link
Member

@bezhermoso bezhermoso commented Jan 14, 2025

Offer an alternative way to integrate with iTerm2

  • Produce Applescript files. These are equivalent to what's already in themes-16/iterm2-scripts/*.sh, but unwrapped into actual AppleScript files
  • Document alternative instructions involving copying the Applescript theme into iTerm2's scripts directory that is auto-loaded on startup (documentation), and why you might want to do it this way.

@bezhermoso bezhermoso requested review from a team as code owners January 14, 2025 08:08
@bezhermoso bezhermoso requested review from martinlindhe and JamyGolden and removed request for a team January 14, 2025 08:08
Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the shell script version of these files since this seems like a better way to work with it?

@bezhermoso
Copy link
Member Author

bezhermoso commented Jan 14, 2025

Makes sense to me. Instead of removing them outright, I've updated those scripts to output some help text to guide users how to migrate. What do you think?

@bezhermoso bezhermoso force-pushed the bezhermoso/iterm2/iterm2-scpt branch 3 times, most recently from 0792a91 to 9030ced Compare January 14, 2025 18:27
@bezhermoso bezhermoso force-pushed the bezhermoso/iterm2/iterm2-scpt branch from 9030ced to 3936cf2 Compare January 14, 2025 18:28
@bezhermoso bezhermoso requested a review from JamyGolden January 14, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants