Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): no-deep-imports add Windows-OS support #2741

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Windows has file paths like this:

C:\\Users\\nsbarsukov\\WebstormProjects\\taiga-ui\\projects\\core\\directives\\hint\\hint.component.ts

I know, it looks terrible :peka:

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 20, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 2c39a60):

https://taiga-ui--pr2741-no-deep-imports-esli-frvjofeh.web.app

(expires Wed, 21 Sep 2022 15:14:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #2741 (2c39a60) into main (5edfedb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2741   +/-   ##
=======================================
  Coverage   56.67%   56.67%           
=======================================
  Files         956      956           
  Lines        9237     9237           
  Branches     1894     1894           
=======================================
  Hits         5235     5235           
  Misses       3591     3591           
  Partials      411      411           
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.12% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 62.86% <ø> (ø)
kit 61.50% <ø> (ø)
summary 56.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nsbarsukov nsbarsukov merged commit e54e3de into main Sep 21, 2022
@nsbarsukov nsbarsukov deleted the no-deep-imports-eslint-rule-fix branch September 21, 2022 07:24
@well-done-bot
Copy link

well-done-bot bot commented Sep 21, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants