Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): broken no-deep-imports on Windows-OS #3053

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Same problem as here:
#2741

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 11, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 11, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
323.37KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.07KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 23169d3):

https://taiga-ui--pr3053-no-deep-import-eslin-pv52zlp3.web.app

(expires Sat, 12 Nov 2022 07:28:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@nsbarsukov nsbarsukov changed the title [WIP] fix(eslint-plugin): broken no-deep-imports on Windows-OS fix(eslint-plugin): broken no-deep-imports on Windows-OS Nov 11, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review November 11, 2022 07:31
@nsbarsukov nsbarsukov merged commit a3451c2 into main Nov 11, 2022
@nsbarsukov nsbarsukov deleted the no-deep-import-eslint-fix branch November 11, 2022 07:53
@well-done-bot
Copy link

well-done-bot bot commented Nov 11, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants