TSDataset 2.0 #956
Merged
TSDataset 2.0 #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tsdataset_2 #956 +/- ##
==============================================
Coverage ? 83.75%
==============================================
Files ? 132
Lines ? 7792
Branches ? 0
==============================================
Hits ? 6526
Misses ? 1266
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🚀 Deployed on https://deploy-preview-956--etna-docs.netlify.app |
Mr-Geekman
reviewed
Sep 26, 2022
| for transform in self.transforms: | ||
| tslogger.log(f"Transform {repr(transform)} is applied to dataset") | ||
| df = transform.transform(df) | ||
| ts = TSDataset(df=df, freq=self.freq) |
There was a problem hiding this comment.
Is it working? What about regressors and known future? It seems like we are losing this information here.
There was a problem hiding this comment.
Added comment
Mr-Geekman
reviewed
Sep 26, 2022
Mr-Geekman
reviewed
Sep 26, 2022
Mr-Geekman
reviewed
Sep 26, 2022
Mr-Geekman
suggested changes
Sep 26, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Sep 27, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 2, 2023
alex-hse-repository
added a commit
that referenced
this pull request
Feb 22, 2023
alex-hse-repository
added a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #876