-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Geekman
changed the title
Add regressor property to
Add regressors property to Sep 22, 2021
TSDataset
TSDataset
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 88.03% 88.08% +0.04%
==========================================
Files 55 55
Lines 2541 2551 +10
==========================================
+ Hits 2237 2247 +10
Misses 304 304
Continue to review full report at Codecov.
|
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
julia-shenshina
approved these changes
Oct 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (checklist)
make lint
(poetry install -E style
).pytest tests/
?Type of Change
Proposed Changes
Add
regressors
property toTSDataset
which returns dict where keys are segments and values are regressor columns for these segments.Rewrite
make_future
to use this new property.Related Issue
#75.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Closing issues
Closes #75.