Skip to content

Implementing PatchTS model #1308

Merged
merged 21 commits into from
Jul 19, 2023
Merged

Implementing PatchTS model #1308

merged 21 commits into from
Jul 19, 2023

Conversation

malodetz
Copy link
Collaborator

@malodetz malodetz commented Jul 5, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

See #1277

Closing issues

Closes #1277

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #1308 (e857cb0) into master (41440d8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
+ Coverage   89.01%   89.09%   +0.08%     
==========================================
  Files         203      204       +1     
  Lines       12504    12634     +130     
==========================================
+ Hits        11130    11256     +126     
- Misses       1374     1378       +4     
Impacted Files Coverage Δ
etna/models/nn/__init__.py 100.00% <100.00%> (ø)
etna/models/nn/patchts.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 01:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 18:08 Inactive
etna/models/nn/patchts.py Outdated Show resolved Hide resolved
etna/models/nn/patchts.py Show resolved Hide resolved
etna/models/nn/patchts.py Outdated Show resolved Hide resolved
etna/models/nn/patchts.py Show resolved Hide resolved
etna/models/nn/patchts.py Outdated Show resolved Hide resolved
etna/models/nn/patchts.py Outdated Show resolved Hide resolved
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add examples to notebook?

@github-actions github-actions bot temporarily deployed to pull request July 9, 2023 16:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 07:17 Inactive
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 09:58 Inactive
@malodetz malodetz requested a review from martins0n July 10, 2023 10:07
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 10:08 Inactive
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linter errors please

etna/models/nn/patchts.py Show resolved Hide resolved
etna/models/nn/patchts.py Outdated Show resolved Hide resolved
examples/NN_examples.ipynb Show resolved Hide resolved
malodetz added 4 commits July 12, 2023 10:12
# Conflicts:
#	etna/models/nn/__init__.py
#	examples/NN_examples.ipynb
@github-actions github-actions bot temporarily deployed to pull request July 13, 2023 19:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 15, 2023 14:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 15, 2023 14:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 15, 2023 15:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 17, 2023 18:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 17, 2023 18:52 Inactive
@malodetz malodetz requested a review from martins0n July 18, 2023 07:08
martins0n
martins0n previously approved these changes Jul 18, 2023
@github-actions github-actions bot temporarily deployed to pull request July 18, 2023 07:28 Inactive
@martins0n martins0n self-requested a review July 18, 2023 07:51
@github-actions github-actions bot temporarily deployed to pull request July 18, 2023 19:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 18, 2023 23:26 Inactive
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit 681d8e1 into master Jul 19, 2023
@martins0n martins0n deleted the issue-1277 branch July 19, 2023 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PatchTS model
3 participants