Add tsfresh into optional dependencies
#1246
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Mr-Geekman
changed the title
tsfresh into optional dependanciestsfresh into optional dependencies
| from etna.experimental.classification.feature_extraction.base import BaseTimeSeriesFeatureExtractor | ||
| from etna.experimental.classification.utils import padd_single_series | ||
|
|
||
| if SETTINGS.classification_required: |
There was a problem hiding this comment.
Are we ok with this?
There was a problem hiding this comment.
Don't get how it works, if user don't have pyts, what happens when he try to instantiate WEASEL?
There was a problem hiding this comment.
We have the same logic with NNs, look at models/base.py.
There was a problem hiding this comment.
I reworked importing logic. Probably, it will work better and more clear.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 87.86% 87.65% -0.21%
==========================================
Files 186 175 -11
Lines 10627 10322 -305
==========================================
- Hits 9337 9048 -289
+ Misses 1290 1274 -16
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'm not really sure that we want to make |
|
🚀 Deployed on https://deploy-preview-1246--etna-docs.netlify.app |
Before submitting (must do checklist)
Proposed Changes
Look #1245.
Closing issues
Closes #1245.