-
Notifications
You must be signed in to change notification settings - Fork 80
Add default params_to_tune
for DateFlagsTransform
, TimeFlagsTransform
, SpecialDaysTransform
, FourierTransform
#1228
Conversation
…Transform, SpecialDaysTransform, FourierTransform
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## automl-2.0 #1228 +/- ##
=============================================
Coverage ? 69.50%
=============================================
Files ? 177
Lines ? 10610
Branches ? 0
=============================================
Hits ? 7375
Misses ? 3235
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🚀 Deployed on https://deploy-preview-1228--etna-docs.netlify.app |
FourierTransform(period=7, mods=[1, 4]), | ||
], | ||
) | ||
def test_params_to_tune_with_mods(transform, ts_trend_seasonal): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure does we want make this test instead of the previous one for all models, transforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that it is better to return the empty grid for this case
FourierTransform(period=7, mods=[1, 4]), | ||
], | ||
) | ||
def test_params_to_tune_with_mods(transform, ts_trend_seasonal): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that it is better to return the empty grid for this case
Before submitting (must do checklist)
Proposed Changes
Look at #1221.
Closing issues
Closes #1221.