Add params_to_tune for HoltWintersModel, HoltModel and SimpleExpSmoothingModel
#1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2023 13:24
# Conflicts: # CHANGELOG.md
|
🚀 Deployed on https://deploy-preview-1209--etna-docs.netlify.app |
Mr-Geekman
commented
Apr 6, 2023
|
|
||
|
|
||
| class HoltModel( | ||
| PerSegmentModelMixin, |
There was a problem hiding this comment.
If we keep inherit HoldModel from HoltWintersModel we will get the error during to_dict because we don't save parameter exponential anywhere inside HoldModel. It is concerning that we haven't face this error before.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## automl-2.0 #1209 +/- ##
=============================================
Coverage ? 87.74%
=============================================
Files ? 177
Lines ? 10565
Branches ? 0
=============================================
Hits ? 9270
Misses ? 1295
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
brsnw250
suggested changes
Apr 7, 2023
4 tasks
added 5 commits
April 7, 2023 14:06
# Conflicts: # CHANGELOG.md
brsnw250
approved these changes
Apr 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look at #1195.
Closing issues
Closes #1195.