Skip to content

Implement forecast decomposition for ARIMA-like models #1174

Merged
merged 13 commits into from
Mar 23, 2023
Merged

Implement forecast decomposition for ARIMA-like models #1174

merged 13 commits into from
Mar 23, 2023

Conversation

brsnw250
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #1149

@brsnw250 brsnw250 self-assigned this Mar 21, 2023
@github-actions
Copy link

github-actions bot commented Mar 21, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-1174--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 21, 2023 10:03 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023 •
edited
Loading

Codecov Report

Merging #1174 (c80f3e9) into master (df78d2e) will increase coverage by 0.40%.
The diff coverage is 98.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   87.22%   87.62%   +0.40%     
==========================================
  Files         166      177      +11     
  Lines        9962    10326     +364     
==========================================
+ Hits         8689     9048     +359     
- Misses       1273     1278       +5
Impacted Files Coverage Δ
etna/models/autoarima.py 100.00% <ø> (ø)
etna/models/sarimax.py 95.97% <98.30%> (+0.97%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request March 21, 2023 10:32 Inactive
alex-hse-repository
alex-hse-repository suggested changes Mar 21, 2023
View reviewed changes
tests/test_models/test_sarimax_model.py Outdated Show resolved Hide resolved
tests/test_models/test_sarimax_model.py Show resolved Hide resolved
tests/test_models/test_autoarima_model.py Outdated Show resolved Hide resolved
etna/models/sarimax.py Show resolved Hide resolved
etna/models/sarimax.py Show resolved Hide resolved
etna/models/sarimax.py Show resolved Hide resolved
etna/models/sarimax.py Show resolved Hide resolved
etna/models/sarimax.py Show resolved Hide resolved
etna/models/sarimax.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request March 22, 2023 08:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 22, 2023 09:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 22, 2023 09:51 Inactive
alex-hse-repository
alex-hse-repository suggested changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@github-actions github-actions bot temporarily deployed to pull request March 22, 2023 13:04 Inactive
@brsnw250 brsnw250 enabled auto-merge (squash) March 23, 2023 10:46
@github-actions github-actions bot temporarily deployed to pull request March 23, 2023 10:50 Inactive
@alex-hse-repository alex-hse-repository self-requested a review March 23, 2023 11:46
@brsnw250 brsnw250 merged commit 4041a08 into master Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alex-hse-repository alex-hse-repository alex-hse-repository approved these changes

Assignees

@brsnw250 brsnw250

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement forecast decomposition for ARIMA-like models
3 participants
@brsnw250 @codecov-commenter @alex-hse-repository