-
Notifications
You must be signed in to change notification settings - Fork 80
Add SaveNNMixin for fixing saving/loading of NNs #1012
Conversation
Codecov Report
@@ Coverage Diff @@
## inference-v2 #1012 +/- ##
===============================================
Coverage ? 85.91%
===============================================
Files ? 163
Lines ? 8700
Branches ? 0
===============================================
Hits ? 7475
Misses ? 1225
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🚀 Deployed on https://deploy-preview-1012--etna-docs.netlify.app |
This reverts commit c791c99.
This reverts commit 276ec77.
def test_save_load(example_tsds): | ||
horizon = 3 | ||
model = TFTModel(max_epochs=2, learning_rate=[0.1], gpus=0, batch_size=64, loss=MAEPF()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we change loss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably made a mistake. As you can see, this loss is only imported in the previous test and wasn't imported in the whole test file. There are two ways to fix it:
- Import
MAEPF
in this test too. - Use default loss.
I choose the second option.
Before submitting (must do checklist)
Proposed Changes
Look at #1011.
Closing issues
Closes #1011.