Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split e2e tests from unit tests: #725

Merged
merged 2 commits into from
May 10, 2023

Conversation

jacobweinstock
Copy link
Member

Description

This makes it clear that there are 2 different types of tests. Also remove nix in CI for tests. The update to the make build target is to improve the output.

current:

❯ make build
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/tink-server-linux-amd64 \
        ./cmd/tink-server
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/tink-worker-linux-amd64 \
        ./cmd/tink-worker
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/tink-controller-linux-amd64 \
        ./cmd/tink-controller
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/virtual-worker-linux-amd64 \
        ./cmd/virtual-worker

new:

❯ make build
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/tink-server-linux-amd64 ./cmd/tink-server 
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/tink-worker-linux-amd64 ./cmd/tink-worker 
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/tink-controller-linux-amd64 ./cmd/tink-controller 
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/virtual-worker-linux-amd64 ./cmd/virtual-worker

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #725 (9b533d9) into main (ff98222) will not change coverage.
The diff coverage is n/a.

❗ Current head 9b533d9 differs from pull request most recent head dda0db7. Consider uploading reports for the commit dda0db7 to get more accurate results

@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   55.54%   55.54%           
=======================================
  Files          26       26           
  Lines        1100     1100           
=======================================
  Hits          611      611           
  Misses        474      474           
  Partials       15       15           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This makes it clear that there are 2 different
types of tests. Also remove nix in CI for tests.
The update to the make build target is to improve
the output.

current:

❯ make build
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/tink-server-linux-amd64 \
        ./cmd/tink-server
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/tink-worker-linux-amd64 \
        ./cmd/tink-worker
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/tink-controller-linux-amd64 \
        ./cmd/tink-controller
CGO_ENABLED=0 \
GOOS=linux \
GOARCH=amd64 \
go build \
         \
        -o ./bin/virtual-worker-linux-amd64 \
        ./cmd/virtual-worker

new:

❯ make build
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/tink-server-linux-amd64 ./cmd/tink-server
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/tink-worker-linux-amd64 ./cmd/tink-worker
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/tink-controller-linux-amd64 ./cmd/tink-controller
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build  -o ./bin/virtual-worker-linux-amd64 ./cmd/virtual-worker

Signed-off-by: Jacob Weinstock <[email protected]>
We're getting: "warning: -s is deprecated as it is always enabled"
The buf.lock was updated after a make verify.

Signed-off-by: Jacob Weinstock <[email protected]>
@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label May 10, 2023
@chrisdoherty4
Copy link
Member

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

queue

🛑 The pull request has been removed from the queue

Pull request #725 has been dequeued due to failing checks or checks timeout.

You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jacobweinstock jacobweinstock merged commit eef6545 into tinkerbell:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants