-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core agent business logic #705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feature/agent
branch
from
April 6, 2023 01:29
8d59798
to
ec5756a
Compare
chrisdoherty4
changed the title
Add tink server-worker workflow v2 proto
Add core Tinkerbell agent business logic
Apr 6, 2023
chrisdoherty4
force-pushed
the
feature/agent
branch
from
April 6, 2023 01:39
ec5756a
to
738a941
Compare
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 52.73% 55.54% +2.80%
==========================================
Files 23 26 +3
Lines 986 1100 +114
==========================================
+ Hits 520 611 +91
- Misses 454 474 +20
- Partials 12 15 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
force-pushed
the
feature/agent
branch
6 times, most recently
from
April 11, 2023 14:33
ef19efb
to
bfbfded
Compare
chrisdoherty4
force-pushed
the
feature/agent
branch
6 times, most recently
from
April 11, 2023 15:26
bd143db
to
1573844
Compare
chrisdoherty4
changed the title
Add core Tinkerbell agent business logic
Add core agent business logic
Apr 11, 2023
chrisdoherty4
force-pushed
the
feature/agent
branch
from
April 11, 2023 15:41
1573844
to
e7e3aec
Compare
chrisdoherty4
commented
Apr 11, 2023
chrisdoherty4
force-pushed
the
feature/agent
branch
from
April 25, 2023 13:58
7026e91
to
45b9b7c
Compare
chrisdoherty4
force-pushed
the
feature/agent
branch
from
May 6, 2023 22:04
45b9b7c
to
3d710db
Compare
Closed
chrisdoherty4
force-pushed
the
feature/agent
branch
2 times, most recently
from
May 9, 2023 15:45
e549e77
to
5fe235f
Compare
jacobweinstock
approved these changes
May 9, 2023
Signed-off-by: Chris Doherty <[email protected]>
chrisdoherty4
force-pushed
the
feature/agent
branch
from
May 9, 2023 18:39
5fe235f
to
ae7fc75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds core business logic for the new tink agent component. The agent will replace the tink worker and can therefore be considered a re-write. Re-writing the worker has allowed us to remove unsupported functionality such as multi-worker workflows that were implemented in the previous Tinkerbell versions as 'tasks'.
The core business logic leverages a transport to retrieve workflows. It communicates workflow progression via events. It runs workflows serially rejecting requests to run concurrently with an explicit
event.WorkflowRejected
event. It assumes enforcement of state machines will be performed by the server component it interacts with.Finally, the logging around the agent has been significantly improved to reflect exactly what's happening as it transitions between actions.
Relevant designs/PRs
Future work
Separate PRs will introduce container runtime and transport implementations. See the Tink agent PoC for a reference.