Fix of template CRD example #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
=======================================
Coverage 48.26% 48.26%
=======================================
Files 18 18
Lines 951 951
=======================================
Hits 459 459
Misses 484 484
Partials 8 8 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
thanks @AleksandrNull ! mind signing the commit? |
1. Prepend writefile image with quay registry path 2. kexec version fix Signed-off-by: Aleksandr Shaposhnikov <[email protected]>
AleksandrNull
force-pushed
the
fix_example_crds
branch
from
e6275eb
to
80accbd
Compare
jacobweinstock
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why is this needed
Examples do not work out-of-the-box
Tested at my local setup as-is