Clean up tink worker; remove os.Exit; ensure valid container names: #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
==========================================
+ Coverage 48.86% 50.45% +1.58%
==========================================
Files 20 20
Lines 1017 995 -22
==========================================
+ Hits 497 502 +5
+ Misses 514 487 -27
Partials 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -130,7 +130,6 @@ func initViper(logger log.Logger, cmd *cobra.Command) error { | |||
| logger.With("configFile", viper.ConfigFileUsed()).Error(err, "could not load config file") | |||
| return err | |||
| } | |||
| logger.Info("no config file found") | |||
| @@ -76,13 +77,22 @@ func (m *containerManager) CreateContainer(ctx context.Context, cmd []string, wf | |||
|
|
|||
| hostConfig.Binds = append(hostConfig.Binds, action.GetVolumes()...) | |||
| l.With("command", cmd).Info("creating container") | |||
| resp, err := m.cli.ContainerCreate(ctx, config, hostConfig, nil, nil, action.GetName()) | |||
| name := makeValidContainerName(action.GetName()) | |||
There was a problem hiding this comment.
I forgot about this, well remembered!
chrisdoherty4
previously approved these changes
Dec 23, 2022
Removing numerous `os.Exit` calls means that tink worker wont require a restart for action execution failures. This commit also allows action names to contain spaces without the action failing to run. Signed-off-by: Jacob Weinstock <[email protected]>
With the worker now not erroring out this e2e test needed updated. Signed-off-by: Jacob Weinstock <[email protected]>
It appears the template library reports a
different error in Go > 1.18 with respect to
a missing `}` in a template. (`{{.device_1}`, for example).
Signed-off-by: Jacob Weinstock <[email protected]>
This removes more unneeded code and drops the use of `goto` statements. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
server-refactor
branch
from
8561647
to
f820d1d
Compare
chrisdoherty4
approved these changes
Dec 23, 2022
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at fdfecb9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing numerous
os.Exitcalls means that tinkworker wont require a restart for action execution failures. This commit also allows action names to contain spaces without the action failing to run.
Why is this needed
Fixes: #463
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: