Error when template for workflow doesn't exist #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
fix/workflows-not-reconciling
branch
from
e4ecade
to
b35271d
Compare
chrisdoherty4
commented
Jun 21, 2022
| @@ -36,6 +36,9 @@ func NewController(kubeClient client.Client) *Controller { | |||
| // +kubebuilder:rbac:groups=tinkerbell.org,resources=workflows;workflows/status,verbs=get;list;watch;update;patch;delete | |||
|
|
|||
| func (c *Controller) Reconcile(ctx context.Context, req reconcile.Request) (reconcile.Result, error) { | |||
| logger := controllerruntime.LoggerFrom(ctx) | |||
| logger.Info("Reconciling") | |||
There was a problem hiding this comment.
This adds some useful information about the object under reconciliation. I intend on expanding this throughout the workflow controller.
jacobweinstock
previously approved these changes
Jun 21, 2022
When the template referenced by a workflow doesn't exist we need to throw an error to trigger requeueing continuously until the template becomes available. If it doesn't, logging will indicate as much as it will note the errors. Signed-off-by: Chris Doherty <[email protected]>
chrisdoherty4
force-pushed
the
fix/workflows-not-reconciling
branch
from
b35271d
to
19b68be
Compare
jacobweinstock
approved these changes
Jun 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 44.54% 44.63% +0.09%
==========================================
Files 61 61
Lines 3518 3524 +6
==========================================
+ Hits 1567 1573 +6
Misses 1869 1869
Partials 82 82
Continue to review full report at Codecov.
|
Merged
mergify bot
added a commit
that referenced
this pull request
Aug 29, 2022
I'm a maintainer of several other services often related to the Kuberenetes back-end/Kubernetes controllers and I'm taking ownership for a lot of release synchronization making it both appropriate and necessary for me to maintain aspects of the Tink repository. Requirements: - I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - I have subscribed to the [tinkerbell-contributors e-mail list](https://groups.google.com/g/tinkerbell-contributors) - I am actively contributing to 1 or more Tinkerbell subprojects Here is a list of non-trival PRs I have been the primary reviewer on: #596 #628 #614 I have also made a number of code contributions to this repository, here are a few of them: #638 #631 #626 #622 #612 I have also raised various issues and am driving the releasing across Tinkerbell including in this repository. Requesting consideration of expedited responsibilities: yes Sponsors: - @mmlb (Maintainer) - @micahhausler (Maintainer) - @jacobweinstock (Core contributor in other Tinkerbell repositories)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the template referenced by a workflow doesn't exist we need to
throw an error to trigger requeueing continuously until the template
becomes available. If it doesn't, logging will indicate as much as it
will note the errors.