Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose indexing funcs #620

Merged
merged 1 commit into from
May 6, 2022
Merged

Expose indexing funcs #620

merged 1 commit into from
May 6, 2022

Conversation

micahhausler
Copy link
Contributor

Signed-off-by: Micah Hausler [email protected]

Description

Making these functions public will allow other packages (such as Boots) to reuse these functions without needing to import the entire manager.

@micahhausler
Expose indexing funcs
80f20f8 
Signed-off-by: Micah Hausler <[email protected]>
@codecov
Copy link

codecov bot commented May 6, 2022 •
edited
Loading

Codecov Report

Merging #620 (80f20f8) into main (f48c79b) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          61       61           
  Lines        3509     3509           
=======================================
  Hits         1567     1567           
  Misses       1860     1860           
  Partials       82       82
Impacted Files Coverage Δ
pkg/controllers/manager.go 40.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48c79b...80f20f8. Read the comment docs.

jacobweinstock
jacobweinstock approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label May 6, 2022
@mergify mergify bot merged commit 97aa134 into tinkerbell:main May 6, 2022
@micahhausler micahhausler mentioned this pull request May 9, 2022
Merged
mergify bot added a commit to tinkerbell/smee that referenced this pull request May 9, 2022
@mergify
Import index funcs from Tink (#268)
c670ca8 
Signed-off-by: Micah Hausler <[email protected]>

## Description

This change imports indexing functions from Tinkerbell and deduplicates logic copied into boots. Follow up from tinkerbell/tink#620
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobweinstock jacobweinstock jacobweinstock approved these changes

Assignees
No one assigned
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@micahhausler @jacobweinstock @displague