Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues from #613 #615

Merged
merged 6 commits into from
May 3, 2022
Merged

Fix some issues from #613 #615

merged 6 commits into from
May 3, 2022

Commits on May 3, 2022

  1. make: update toolsBins for cmds with version in module path 

    Signed-off-by: Manuel Mendez <[email protected]>
    @mmlb
    mmlb committed May 3, 2022
    Configuration menu
    Copy the full SHA
    4487a27 View commit details
    Browse the repository at this point in the history

  2. Add kustomize 

    Signed-off-by: Manuel Mendez <[email protected]>
    @mmlb
    mmlb committed May 3, 2022
    Configuration menu
    Copy the full SHA
    9a18025 View commit details
    Browse the repository at this point in the history

  3. kube.mk: Split generate-manifests into smaller targets 

    This way make can generate them in parallel if possible.

Signed-off-by: Manuel Mendez <[email protected]>
    @mmlb
    mmlb committed May 3, 2022
    Configuration menu
    Copy the full SHA
    26f097f View commit details
    Browse the repository at this point in the history

  4. Make: Add generate-manifests as a dep of generated 

    This way we won't have out dated k8s manifests.

Also regenerate the manifests.

Signed-off-by: Manuel Mendez <[email protected]>
    @mmlb
    mmlb committed May 3, 2022
    Configuration menu
    Copy the full SHA
    519ce0e View commit details
    Browse the repository at this point in the history

  5. kube.mk: Use tools.go setup for kustomize 

    Signed-off-by: Manuel Mendez <[email protected]>
    @mmlb
    mmlb committed May 3, 2022
    Configuration menu
    Copy the full SHA
    0941c5a View commit details
    Browse the repository at this point in the history

  6. kube: Rework k8s release manifests 

    We shouldn't be patching a git tracked file as part of the build because
then we'd have to go back and checkout the changes. Unfortunately this means
we need to copy the whole directory tree so that kustomize will pick up the
edited files.

I also fixed a typo that used the TINK_SERVER_IMAGE_NAME for the manager.

I also cleaned up the recursive uses of make since they are considered
harmful and dropped `release` as that should be for the whole project not
just the k8s manifests.

Signed-off-by: Manuel Mendez <[email protected]>
    @mmlb
    mmlb committed May 3, 2022
    Configuration menu
    Copy the full SHA
    d303dc2 View commit details
    Browse the repository at this point in the history