Fix help and usage for tink template update
#587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 38.52% 38.44% -0.09%
==========================================
Files 53 53
Lines 3561 3569 +8
==========================================
Hits 1372 1372
- Misses 2092 2100 +8
Partials 97 97
Continue to review full report at Codecov.
|
mergify bot
added a commit
that referenced
this pull request
Feb 9, 2022
## Description Fixes an issue with `tink template update` using stdin, follow up to #587 ## Why is this needed #587 didn't fully add support for sdin with `tink template update`, it still threw an error if content wasn't provided using the `--path` argument. ## How Has This Been Tested? Tested manually against a Tinkerbell environment created using HEAD of sandbox ## How are existing users impacted? What migration steps/scripts do we need? Existing users not impacted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tink template updatepreviously had the wrong help output (stating argument is--fileinstead of--path) and did not support providing the updated template data over stdin.Why is this needed
docker exec, so supporting stdin makes it easier for them to use the commandHow Has This Been Tested?
TODO
How are existing users impacted? What migration steps/scripts do we need?
Should not affect existing users, only fix issues users are already encountering.