Drop json rpc gateway support #583
Conversation
|
I realized you have a dummy client @micahhausler and we didn't clarify it in slack so pinging you here. I hope its grpc based :D. |
The virtual worker just uses the gRPC interface like tink-worker. No risk here from me |
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 38.48% 43.39% +4.91%
==========================================
Files 53 51 -2
Lines 3565 3104 -461
==========================================
- Hits 1372 1347 -25
+ Misses 2096 1671 -425
+ Partials 97 86 -11
Continue to review full report at Codecov.
|
mmlb
force-pushed
the
drop-json-rpc
branch
4 times, most recently
from
84a5656
to
12e9555
Compare
|
Yep it should, maybe you need to update? https://direnv.net/man/direnv-stdlib.1.html#codedotenvifexists-ltdotenvpathgtcode |
Make use of direnv's stdlib having `has` which replaces the old `which ... &>/dev/null`. This also sources env vars from .env files which should not be added to git and allow for local user to override/add things without git trying to track it. Finally, add ./bin to both PATH and GOBIN to avoid contamination of global GOBIN. Signed-off-by: Manuel Mendez <[email protected]>
lg is already of copy of the arg so theres no need to create a function variable to copy the arg when just naming it logger would do. Signed-off-by: Manuel Mendez <[email protected]>
Yay one global variable down, many more to go. Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
Pretty sure no one is using this over grpc rpc support and thus is a lot of useless complexity. So lets get rid of unused code! Signed-off-by: Manuel Mendez <[email protected]>
http_handlers.go only contained the logic for translating json rpc -> grpc in
the Register{Hardware,Template,Workflow}ServiceHandlerFromEndpoint functions.
Since we don't need them they can go away. Since there's not http_handlers.go
we don't need http_handlers_test.go either.
Signed-off-by: Manuel Mendez <[email protected]>
These are no longer needed. Signed-off-by: Manuel Mendez <[email protected]>
Description
Drop all code dealing with json rpc.
Why is this needed
Its likely unused code which has some weird code (:eye: runtime.String) that make other PRs more tedious (#567, also I want to drop the self-signed
/certstuff too) to implement.How Has This Been Tested?
go buildand CI.How are existing users impacted? What migration steps/scripts do we need?
No impact I suspect (and hope). I know of 3 other tink clients and they all use grpc: